[ZEPPELIN-923] Apply new mechanism to ShellInterpreter #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
😄 |
Contributor
Author
|
@jongyoul But CI is failed :( Is this relevant with this PR ? |
Member
|
@AhyoungRyu One looks irrelevant and another is about rat plugin. you need to exclude interpreter-setting.json in a rat plugin. |
Contributor
Author
|
@jongyoul I see. Okay Thanks for letting me know :) |
Contributor
|
@AhyoungRyu have made a fix #4492.7 failed #958. Can you rebase with master, and re-trigger ? And yes other is |
Contributor
Author
|
@jongyoul @prabhjyotsingh I excluded |
Contributor
|
LGTM. |
Contributor
|
Merging this if no more discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR applies the new interpreter registration mechanism to Shell interpreter.
What type of PR is it?
Improvement
Todos
shellInterpreter.javaand addinterpreter-setting.jsonunder theshell/src/main/resourcesWhat is the Jira issue?
ZEPPELIN-923
How should this be tested?
interpreter/shandconf/interpreter.jsonScreenshots (if appropriate)
Questions: